sch-UID2-5355 refactoring kms client builder #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private final KmsClientBuilder kmsClientBuilder; | ||
|
|
||
| public JWTTokenProvider(JsonObject config, KmsClientBuilder clientBuilder) { | ||
| public JWTTokenProvider(JsonObject config) { |
Contributor
There was a problem hiding this comment.
I think it makes more sense to pass in a Supplier<KmsClientBuilder>
| KmsClient client = null; | ||
| try { | ||
| client = getKmsClient(this.kmsClientBuilder, this.config); | ||
| client = getKmsClient(kmsClientBuilderSupplier.get(), this.config); |
Contributor
There was a problem hiding this comment.
this. kmsClientBuilderSupplier to be consistent
vishalegbert-ttd
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.